[
https://issues.apache.org/jira/browse/IGNITE-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635144#comment-16635144
]
ASF GitHub Bot commented on IGNITE-8803:
----------------------------------------
GitHub user agoncharuk opened a pull request:
https://github.com/apache/ignite/pull/4886
IGNITE-8803 Corrected output for quiet mode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4886
----
commit 6c7f93c3cf948d1d51ed4c3ed64397ec252a43e3
Author: Alexey Goncharuk <alexey.goncharuk@...>
Date: 2018-10-02T08:24:21Z
IGNITE-8803 Corrected output for quiet mode
----
> Need to fix Ignite QUIET log output
> -----------------------------------
>
> Key: IGNITE-8803
> URL: https://issues.apache.org/jira/browse/IGNITE-8803
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Reporter: Dmitriy Setrakyan
> Assignee: Alexey Goncharuk
> Priority: Blocker
> Fix For: 2.7
>
>
> {color:#004000}We need to fix QUIET log mode. Here is an example of a single
> node output after another node joined and left 3 times:{color}
>
> {quote}[22:50:23] Ignite node started OK (id=931fcf60)
> [22:50:23] Topology snapshot [ver=4, servers=2, clients=0, CPUs=8,
> offheap=6.4GB, heap=2.0GB]
> [22:50:23] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:50:23] Data Regions Configured:
> [22:50:23] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> [22:50:28] Topology snapshot [ver=5, servers=1, clients=0, CPUs=8,
> offheap=3.2GB, heap=1.0GB]
> [22:50:28] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:50:28] Data Regions Configured:
> [22:50:28] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> [22:50:36] Topology snapshot [ver=6, servers=2, clients=0, CPUs=8,
> offheap=6.4GB, heap=2.0GB]
> [22:50:36] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:50:36] Data Regions Configured:
> [22:50:36] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> [22:50:43] Topology snapshot [ver=7, servers=1, clients=0, CPUs=8,
> offheap=3.2GB, heap=1.0GB]
> [22:50:43] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:50:43] Data Regions Configured:
> [22:50:43] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> [22:50:51] Topology snapshot [ver=8, servers=2, clients=0, CPUs=8,
> offheap=6.4GB, heap=2.0GB]
> [22:50:51] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:50:51] Data Regions Configured:
> [22:50:51] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> [22:51:54] Topology snapshot [ver=9, servers=1, clients=0, CPUs=8,
> offheap=3.2GB, heap=1.0GB]
> [22:51:54] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:51:54] Data Regions Configured:
> [22:51:54] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> [22:52:02] Topology snapshot [ver=10, servers=2, clients=0, CPUs=8,
> offheap=6.4GB, heap=2.0GB]
> [22:52:02] ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A,
> clusterState=ACTIVE]
> [22:52:02] Data Regions Configured:
> [22:52:02] ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB,
> persistenceEnabled=false]
> {quote}
>
> We are printing out the same information over and over again. For example,
> regions configuration does not change, why do we print it out every time? The
> same goes for the node ID, it stays constant. Moreover, we should never be
> printing out full node IDs in quite mode.
>
> I suggest we fix it as follows:
> # Print out data regions once on startup, right before we print out that
> _"Ignite node started OK (id=931fcf60)"_
> # Remove _"^--Node [...]"_ printout underneath topology snapshot altogether
> # Rename "clusterState=ACTIVE" to "state=ACTIVE" and add it to the topology
> snapshot line.
> # Rename "persistenceEnabled" to "persistence"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
