[ https://issues.apache.org/jira/browse/IGNITE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644616#comment-16644616 ]
Amelchev Nikita commented on IGNITE-9754: ----------------------------------------- Hi [~oignatenko], I have reviewed you PR and this test still flaky. With your changes, it fails with assertion reason: {noformat} junit.framework.AssertionFailedError: Expecting no active futures: node=90975eee-f350-4511-8807-58b7e7400000 at junit.framework.Assert.fail(Assert.java:57) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.TestCase.assertTrue(TestCase.java:192) at org.apache.ignite.testframework.junits.common.GridCommonAbstractTest.checkFutures(GridCommonAbstractTest.java:2002) at org.apache.ignite.internal.processors.cache.transactions.TxRollbackAsyncTest.testRollbackOnTopologyLockPessimistic(TxRollbackAsyncTest.java:1016) at sun.reflect.GeneratedMethodAccessor29.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at junit.framework.TestCase.runTest(TestCase.java:176) at org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2177) at org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:143) at org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2092) at java.lang.Thread.run(Thread.java:745){noformat} Check your PR and run at least some hundred times on TC, please. > Increase timeout waiting for commitLatch in test > TxRollbackAsyncWithPersistenceTest.testRollbackOnTopologyLockPessimistic > ------------------------------------------------------------------------------------------------------------------------- > > Key: IGNITE-9754 > URL: https://issues.apache.org/jira/browse/IGNITE-9754 > Project: Ignite > Issue Type: Bug > Affects Versions: 2.6 > Reporter: Oleg Ignatenko > Assignee: Oleg Ignatenko > Priority: Major > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > > Current timeout for {{commitLatch}} in test > {{TxRollbackAsyncWithPersistenceTest.testRollbackOnTopologyLockPessimistic}} > is 10 seconds. > This looks insufficient to make a compelling reason that test failure > indicates a problem in the implementation. For example log of this [recent > failure at > Teamcity|https://ci.ignite.apache.org/viewLog.html?buildId=1970040&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Cache7] > suggests that there were just a couple of non-critical delays for a few > seconds that made test fail. > Suggest to increase timeout from 10 seconds to 60, so that in case if test > fails waiting on the latch one could assume with reasonable certainty that > something is wrong with the implementation or infrastructure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)