[
https://issues.apache.org/jira/browse/IGNITE-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646918#comment-16646918
]
Uday Kale commented on IGNITE-7054:
-----------------------------------
[~vkulichenko],
Thanks for the review. Following are the replies to the requested changes:
# I will change this to take a single argument {{KeyPair}} which holds both
{{PrivateKey}} and {{PublicKey}}. Didn't find any other such cases.
# [No questions]
# I have implemented this on the same lines as
{{TcpDiscoveryS3IpFinder#initClient()}}. Here since, the setters are used to
pass the initialisation params, I will have to check for them and lazy
initialise the clients. If its OK to pass these params from constructor instead
of setters, I can remove such code.
# I have made them package-private for unit test purposes. See
{{AwsKmsEncryptionServiceTest#testEncryptDecrypt() Line:54}}.
# The encrypted bytes under the default java character encoding is returning
some special characters. These special characters are illegal in S3. See
characters to avoid under
[https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html]. Base32
encoding has all characters that are acceptable by AWS S3. See
[https://en.wikipedia.org/wiki/Base32].
> S3 IP finder: support client side encryption
> --------------------------------------------
>
> Key: IGNITE-7054
> URL: https://issues.apache.org/jira/browse/IGNITE-7054
> Project: Ignite
> Issue Type: Improvement
> Components: s3
> Affects Versions: 2.3
> Reporter: Valentin Kulichenko
> Assignee: Uday Kale
> Priority: Major
> Fix For: 2.8
>
>
> In case client side encryption [1] is used, it may be required to use
> {{AmazonS3EncryptionClient}} instead of regular {{AmazonS3Client}}. We need
> to add this option to the S3 IP finder, along with any applicable
> configuration parameters.
> [1]
> http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingClientSideEncryption.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
