[ https://issues.apache.org/jira/browse/IGNITE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653788#comment-16653788 ]
Ivan Rakov commented on IGNITE-9719: ------------------------------------ [~AldoRaine], 1. Please mind the code style guide. {noformat} if (cfg.getRebalanceThreadPoolSize() != IgniteConfiguration.DFLT_REBALANCE_THREAD_POOL_SIZE) { U.warn(log, "Setting the rebalance pool size has no effect on the client mode"); // Violation: one liner in braces } // Violation: blank line is required between semantic units cfg.setRebalanceThreadPoolSize(0); {noformat} 2. Why do you intentionally change pool size to 0 on clients? This look suspicious; this property takes no effect on client nodes (at least for now). I'd just remove this line to keep default value. Changing user configuration on startup is bad pattern - usually it complicates debugging. > Extra rebalanceThreadPoolSize check on client node. > --------------------------------------------------- > > Key: IGNITE-9719 > URL: https://issues.apache.org/jira/browse/IGNITE-9719 > Project: Ignite > Issue Type: Improvement > Components: clients > Affects Versions: 2.6 > Reporter: Stanilovsky Evgeny > Assignee: Luchnikov Alexander > Priority: Minor > Fix For: 2.8 > > > No need to check rebalance thread pool size on client side in > IgniteKernal#ackRebalanceConfiguration method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)