[
https://issues.apache.org/jira/browse/IGNITE-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658785#comment-16658785
]
Amelchev Nikita commented on IGNITE-9659:
-----------------------------------------
I have fixed the test:
* Removed anonymous discovery SPI
* Removed race in test communication SPI code
* There was a race between PME and sql-retry. The test fails if PME completed
after node stop and before updating query partitions on sql retry. In this
case, query completed successfully and will not throw the exception.
* Used custom SPI exception instead node stop. Now the test will never be
failed with "Node left during query execution".
[TC
tests|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F5005%2Fhead]
are OK. Mass runs are good too.
[~agoncharuk], could you review, please?
> NonCollocatedRetryMessageSelfTest is flaky
> ------------------------------------------
>
> Key: IGNITE-9659
> URL: https://issues.apache.org/jira/browse/IGNITE-9659
> Project: Ignite
> Issue Type: Test
> Reporter: Alexey Goncharuk
> Assignee: Amelchev Nikita
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.8
>
>
> https://ci.ignite.apache.org/viewLog.html?buildId=1881869&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Queries2#testNameId-2853122976880171731
> A few concerns on the test code:
> 1) What is the point of setting an anonymous discovery SPI? The overridden
> method is identical to super(), but the new discovery SPI looses test VM IP
> finder which is set by default
> 2) Looks like there is a race in test communication SPI code - there is an if
> - assign block for a volatile variable
> 3) The test fails with "Node left during query execution" - since the node is
> stopped, this should be either an allowed exception, or the test
> communication SPI should be crafted more carefully.
> (FYI: Locally I have this test failing with No CacheException emitted.
> Collection size=10)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
