[
https://issues.apache.org/jira/browse/IGNITE-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659484#comment-16659484
]
ASF GitHub Bot commented on IGNITE-6811:
----------------------------------------
GitHub user pavel-kuznetsov opened a pull request:
https://github.com/apache/ignite/pull/5051
IGNITE-6811: Allowed empty batch in JDBC thin driver.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6811
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5051
----
commit 7cd8faa9280c9708989604f17c1859f25450a6b5
Author: Pavel Kuznetsov <palmihal@...>
Date: 2018-10-22T14:30:01Z
ignite-6811: Added tests that reproduce the bug.
When streaming is OFF we can't perform empty batch neither for Statement
nor for PreparedStatement.
commit 7cd9dd1b250655b19dafd95ad54ced751ab6f3c9
Author: Pavel Kuznetsov <palmihal@...>
Date: 2018-10-22T15:19:38Z
ignite-6811: Fixed empty batch.
Now if empty batch is executed, no error is thrown. Empty updates counts
array is returned. This is done due to usability reasons.
commit 6ed512e24f3e0184f1ad9236dbe2e518942324c4
Author: Pavel Kuznetsov <palmihal@...>
Date: 2018-10-22T15:53:21Z
Merge remote-tracking branch 'origin/master' into ignite-6811
----
> JDBC Thin: SQLException("Batch is empty.") when batch list is empty
> -------------------------------------------------------------------
>
> Key: IGNITE-6811
> URL: https://issues.apache.org/jira/browse/IGNITE-6811
> Project: Ignite
> Issue Type: Bug
> Components: jdbc
> Affects Versions: 2.3
> Reporter: Vasily Bukharev
> Assignee: Pavel Kuznetsov
> Priority: Trivial
>
> The method executeBatch() throws SQLException("Batch is empty.") when batch
> list is empty.
> The api doc of java.sql.Statement.executeBatch()
> does not require an exception to be thrown in such situation.
> I guess it is more convinient for client code if the exception is not thrown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
