[
https://issues.apache.org/jira/browse/IGNITE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670248#comment-16670248
]
ASF GitHub Bot commented on IGNITE-8896:
----------------------------------------
GitHub user Rodion4ik opened a pull request:
https://github.com/apache/ignite/pull/5225
IGNITE-8896
In TcpCommunicationSpi text of message "greater than" replace on "greater
than or equal to" according to conditions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Rodion4ik/ignite ignite-8896
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5225
----
commit 8a312d6087c0608352c49a08cdd31c1f8a65a54e
Author: Rodion4ik <rodion.vlasov@...>
Date: 2018-10-31T14:21:47Z
Update TcpCommunicationSpi.java
----
> Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
> ---------------------------------------------------------------
>
> Key: IGNITE-8896
> URL: https://issues.apache.org/jira/browse/IGNITE-8896
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.5
> Reporter: Dmitry Karachentsev
> Assignee: Rodion
> Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
>
> Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should
> be set to value equal to TcpCommunicationSpi.getMessageQueueLimit().
> But this is wrong, because first checks back pressure limit and sender thread
> will be blocked before slow client check. Also, warning checks the value
> correctly, but message should be "...greater or equal...":
> {code:java}
> if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit >=
> msgQueueLimit) {
> U.quietAndWarn(log, "Slow client queue limit is set to a value
> greater than message queue limit " +
> "(slow client queue limit will have no effect)
> [msgQueueLimit=" + msgQueueLimit +
> ", slowClientQueueLimit=" + slowClientQueueLimit + ']');
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
