[ 
https://issues.apache.org/jira/browse/IGNITE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676726#comment-16676726
 ] 

Pavel Kovalenko commented on IGNITE-9975:
-----------------------------------------

[~akalashnikov] I've looked at your changes. There are several minor concerns 
regarding test:
1) Why do you need enabled P2P? I don't see any custom user classes uploaded 
from the client node.
2) Extract common parameters for declared cache configurations to avoid 
copy-paste.
3) Group/Cache id may be extracted from cacheName using utility method 
CU.cacheId(String)
4) Explicitly set maxSize of default data region to avoid possible OOM on 
TeamCity.

Other things look good to me.

> Possible data loss during starting of the nodes with empty pds
> --------------------------------------------------------------
>
>                 Key: IGNITE-9975
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9975
>             Project: Ignite
>          Issue Type: Bug
>          Components: persistence
>    Affects Versions: 2.4
>            Reporter: Andrey Aleksandrov
>            Assignee: Anton Kalashnikov
>            Priority: Major
>             Fix For: 2.8
>
>         Attachments: reproducer.java
>
>
> Case: 
> 1)Start 3 data nodes and activate the cluster with cache with 1 backup and 
> PartitionLossPolicy.READ_ONLY_SAFE.
> 2)Start client and add the data to your cache. Stop the client
> 3)Stop DN2 and clear it pds and val
> 4)Start DN2. Rebalance will start.
> 5)During rebalance stop DN3.
> 6)Start DN3.
> At this moment some partitions from DN2 marked as LOST and cache size will be 
> less than expected.
> 7) Run resetLostPartitions(caches).
> Now all partitions on DN2 marked as OWNING but cache size is still less than 
> expected.
> Workaround:
> after step 6 do:
> 7)force rebalance using deactivate/activate methods.
> 8)wait for completion of rebalance
> Now cache size is expected but some partitions from DN2 marked as LOST
> 9)Run resetLostPartitions(caches).
> Now cache size is OK and all partitions from DN2 marked as OWNING.
> However, looks like without force rebalance we have data loss here.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to