[jira] [Commented] (IGNITE-9939) [TC Bot] Add visa's cahing and monitoring

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/IGNITE-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676739#comment-16676739
 ] 

ASF GitHub Bot commented on IGNITE-9939:
----------------------------------------

SomeFire commented on a change in pull request #40: IGNITE-9939 [Tc Bot] Add 
visas caсhing and monitoring
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r231087806
 
 

 ##########
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
 ##########
 @@ -58,10 +63,16 @@ public void stop() {
     /**
      * @param srvId Server id.
      * @param prov Credentials.
+     * @param ticket Ticket.
+     * @param branchForTc Branch for TC.
      * @param ticket JIRA ticket name.
      */
-    public void observe(String srvId, ICredentialsProv prov, String ticket, 
Build... builds) {
-        observerTask.addBuild(new BuildsInfo(srvId, prov, ticket, builds));
+    public void observe(String srvId, ICredentialsProv prov, String ticket, 
String branchForTc, Build... builds) {
+        BuildsInfo buildsInfo = new BuildsInfo(srvId, prov, ticket, 
branchForTc, builds);
+
+       visasStorage.put(new VisaRequest(buildsInfo));
 
 Review comment:
   Wrong indentation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [TC Bot] Add visa's cahing and monitoring
> -----------------------------------------
>
>                 Key: IGNITE-9939
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9939
>             Project: Ignite
>          Issue Type: Task
>            Reporter: PetrovMikhail
>            Assignee: PetrovMikhail
>            Priority: Minor
>
> Add visa cahing and monitoring. Handle situation within BuildObserver when 
> build status is "UNKNOWN"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)