[ 
https://issues.apache.org/jira/browse/IGNITE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679636#comment-16679636
 ] 

ASF GitHub Bot commented on IGNITE-10154:
-----------------------------------------

GitHub user agura opened a pull request:

    https://github.com/apache/ignite/pull/5350

    IGNITE-10154 FailureType.SYSTEM_WORKER_BLOCKED always must be in 
ignoredFailureTypes due to a backward compatibility

    …

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agura/incubator-ignite ignite-10154

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5350
    
----
commit a92afd10070cebca9c0c7acbe0ff53cd53b1644c
Author: Andrey Gura <agura@...>
Date:   2018-11-08T11:31:18Z

    IGNITE-10154 FailureType.SYSTEM_WORKER_BLOCKED always must be in 
ignoredFailureType due to a backward compatibility

----


> Critical worker liveness check configuration is non-trivial and inconsistent
> ----------------------------------------------------------------------------
>
>                 Key: IGNITE-10154
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10154
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 2.7
>            Reporter: Artem Budnikov
>            Assignee: Andrey Gura
>            Priority: Major
>             Fix For: 2.7
>
>
> The way the critical thread liveness check is configured has a number of 
> usability issues.
> 1) By default, the liveness check is disabled (i.e. if no failure handler is 
> specified in the configuration). However, if you specify any handler 
> (including the default one), liveness check gets enabled (which is something 
> the users may not want) unless you disable it explicitly.
> 2) Users that use Ignite 2.6 with a configured failure handler will get this 
> check enabled after migrating to Ignite 2.7.
> In the two cases above, the functionality changes in a non-trivial way. 
> Ideally, we need an option that enables this functionality explicitly. A 
> possible example would be to keep liveness check disabled until the user sets 
> the systemWorkerBlockedTimeout to a positive value. (Or the other way around: 
> enable liveness check by default until the user explicitly disables it).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to