[
https://issues.apache.org/jira/browse/IGNITE-8052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691703#comment-16691703
]
ASF GitHub Bot commented on IGNITE-8052:
----------------------------------------
GitHub user pavel-kuznetsov opened a pull request:
https://github.com/apache/ignite/pull/5429
ignite-8432: Test for column name case in PK and CREATE TABLE.
Although, bug have been fixed during IGNITE-8052, added test for this
special case: primary keys list is case sensitive; correct exception
should be thrown if we forgot to quote lower case names in the one place
(columns list/PK list) but quoted in the other.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8432
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5429
----
commit 368303a16553982c3f900dd6f0ca322dd005be68
Author: Pavel Kuznetsov <palmihal@...>
Date: 2018-11-19T13:42:44Z
ignite-8432: Test for column name case in PK and CREATE TABLE.
Although, bug have been fixed during IGNITE-8052, added test for this
special case: primary keys list is case sensitive; correct exception
should be thrown if we forgot to quote lower case names in the one place
(columns list/PK list) but quoted in the other.
----
> Clear error message needed when using a non-existing column name for CREATE
> TABLE primary key
> ---------------------------------------------------------------------------------------------
>
> Key: IGNITE-8052
> URL: https://issues.apache.org/jira/browse/IGNITE-8052
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Minor
> Labels: usability
> Fix For: 2.5
>
>
> On _CREATE TABLE_ with a misspelled column name for _PRIMARY KEY_ we have the
> following error with assertions enabled
> {code:java}
> java.lang.AssertionError
> at
> org.apache.ignite.internal.processors.query.h2.sql.GridSqlQueryParser.parseCreateTable(GridSqlQueryParser.java:1044)
> at
> org.apache.ignite.internal.processors.query.h2.sql.GridSqlQueryParser.parse(GridSqlQueryParser.java:1647)
> at
> org.apache.ignite.internal.processors.query.h2.ddl.DdlStatementsProcessor.runDdlStatement(DdlStatementsProcessor.java:245)
> ...
> {code}
> and when disabled
> {code:java}
> class org.apache.ignite.internal.processors.query.IgniteSQLException: null
> at
> org.apache.ignite.internal.processors.query.h2.ddl.DdlStatementsProcessor.runDdlStatement(DdlStatementsProcessor.java:492)
> at
> org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.doRunPrepared(IgniteH2Indexing.java:1643)
> at
> org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.querySqlFields(IgniteH2Indexing.java:1577)
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
