[
https://issues.apache.org/jira/browse/IGNITE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692971#comment-16692971
]
Oleg Ignatenko edited comment on IGNITE-10174 at 11/20/18 9:50 AM:
-------------------------------------------------------------------
(?) When discussing this change [~EdShangGG] pointed to difference in how empty
test classes are reported when tests are run.
The similarity is that both prior and after the change TC bot disregards empty
test classes and grants the visa (which makes sense if you think of it: since
there are no test cases to run, it means there are no problems to report in
tested code).
What is different though is how such classes are presented.
The old way, execution shows message like
{{ContinuationExamplesSelfTest.initializationError java.lang.Exception: No
runnable methods}} and this warning is muted by the means of TC with the
reference to IGNITE-711 ([example build
#5163|https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_Examples&buildId=2359481&branch_IgniteTests24Java8_Examples=pull/5434/head]).
The new way, execution shows message like
{{junit.framework.AssertionFailedError: No tests found in
org.apache.ignite.examples.ContinuationExamplesSelfTest}} and this warning is
_not_ muted by the means of TC ([example build
#5138|https://ci.ignite.apache.org/viewLog.html?buildId=2353596&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Examples]).
[~dmitry.pavlov] - since you appear to be actively involved with TC bot, we
would appreciate your thoughts here, is above difference important and is it
worth spending effort on making the empty test classes reported the old way
instead of a new one?
was (Author: oignatenko):
(?) When discussing this change [~EdShangGG] pointed to difference in how empty
test classes are reported when tests are run.
The similarity is that both prior and after the change TC bot disregards empty
test classes and grants the visa (which makes sense if you think of it: since
there are no test cases to run, it means there are no problems to report in
tested code.
What is different though is how such classes are presented.
The old way, execution shows message like
{{ContinuationExamplesSelfTest.initializationError java.lang.Exception: No
runnable methods}} and this warning is muted by the means of TC with the
reference to IGNITE-711 ([example build
#5163|https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_Examples&buildId=2359481&branch_IgniteTests24Java8_Examples=pull/5434/head]).
The new way, execution shows message like
{{junit.framework.AssertionFailedError: No tests found in
org.apache.ignite.examples.ContinuationExamplesSelfTest}} and this warning is
_not_ muted by the means of TC ([example build
#5138|https://ci.ignite.apache.org/viewLog.html?buildId=2353596&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Examples]).
[~dmitry.pavlov] - since you appear to be actively involved with TC bot, we
would appreciate your thoughts here, is above difference important and is it
worth spending effort on making the empty test classes reported the old way
instead of a new one?
> migrate examples tests from Junit 3 to 4
> ----------------------------------------
>
> Key: IGNITE-10174
> URL: https://issues.apache.org/jira/browse/IGNITE-10174
> Project: Ignite
> Issue Type: Sub-task
> Affects Versions: 2.6
> Reporter: Oleg Ignatenko
> Assignee: Oleg Ignatenko
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.8
>
>
> If needed, refer parent task for more details.
> This is first task because examples are most publicly visible, relativelly
> small and least risky part of unit tests in the project.
> Steps: 1) create Junit-4 based twin of GridAbstractTest (and all needed
> subclasses), 2) declare GridAbstractTest deprecated with reference to use
> newer API instead 3) change unit tests in examples to use new API
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
