[
https://issues.apache.org/jira/browse/IGNITE-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704720#comment-16704720
]
Taras Ledkov commented on IGNITE-5439:
--------------------------------------
[~alapin], the patch looks good in general.
The SQL tests on TC & protocol compatibility are OK.
My comments:
# You add the method {{JdbcThinTcpIo#sendRequestRaw}} to use for send
{{JdbcQueryCancelRequest}}. Please take a look that {{sendRequest}} and
{{sendBatchRequestNoWaitResponse}} methods. Is it possible to remove code
duplication there (send message)?
#
{{org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo#sendBatchRequestNoWaitResponse}}
TODO comment. Not complete?
# The atomic operations are not used for the flag
{{JdbcThinStatement#canceled}}. Moreover the most flag usages are inside
*synchronize* blocks. Does we really need in {{AtomicBoolean}}?
# Please review my minor changes.
> JDBC thin: support query cancel
> -------------------------------
>
> Key: IGNITE-5439
> URL: https://issues.apache.org/jira/browse/IGNITE-5439
> Project: Ignite
> Issue Type: Task
> Components: jdbc
> Affects Versions: 2.0
> Reporter: Taras Ledkov
> Assignee: Alexander Lapin
> Priority: Major
> Fix For: 2.8
>
>
> The JDBC {{Statement.cancel}} method must be supported.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
