[
https://issues.apache.org/jira/browse/IGNITE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705658#comment-16705658
]
Oleg Ignatenko commented on IGNITE-10422:
-----------------------------------------
(i) Per my review this looks OK to merge. I verified this by importing Ignite
project from branch ignite-10422 into clean installation of IDEA (version
2018.3 Community, on Ubuntu 16.04).
IDE correctly picks inspections from default location, and settings used for
Teamcity checks have the same values that were set per IGNITE-9983 and
IGNITE-10227.
-----
For the sake of completeness I had to mess a bit before I made my IDE mark
unused imports but that doesn't look critical here. This issue seems related to
IGNITE-10227 and overall it looks like in version used for test Idea picks it
by different syntax than what works on Teamcity ("UNUSED_IMPORT" instead of
"UnusedImport"). One option to consider is to have both syntaxes in config file
but I don't insist on that because this approach feels hacky.
> Make {{ignite_inspection.xml}} configuration default on the project level
> -------------------------------------------------------------------------
>
> Key: IGNITE-10422
> URL: https://issues.apache.org/jira/browse/IGNITE-10422
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: inspections
>
> IntelliJ IDEA can perform static code analysis by applying _inspections_ to
> the project code. The inspection analysis process can be easily run from both
> the IDE and the command line. The command line usage of IntelliJ IDEA
> inspections already configured as daily [Inspections(Core)
> TeamCity|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv]
> suite. This approach has proven its convenience and efficiency as part of
> the _TC.Bot_.
> As for the next step, I propose to improve personal productivity of writing
> code by making *{{ignite_inspection.xml}}* configuration default on the
> project level.
> According to [IntelliJ IDEA
> documentation|https://www.jetbrains.com/help/idea/code-inspection.html], the
> inspection profile is recommended to be placed to
> *{{<project>/.idea/inspectionProfiles}}* with name *{{Project_Default.xml}}*.
> This project profile will be shared and accessible for the team members via
> VCS by default.
> Note.
> The build and test procedure of Apache Ignite project will remain IDE
> independent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
