[
https://issues.apache.org/jira/browse/IGNITE-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708292#comment-16708292
]
ASF GitHub Bot commented on IGNITE-10511:
-----------------------------------------
GitHub user voropava opened a pull request:
https://github.com/apache/ignite/pull/5563
IGNITE-10511 removeExplicitNodeLocks() removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-10511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5563.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5563
----
commit b657b8231677b3e9b80ef7b72e1bd7f87e59a69d
Author: Pavel Voronkin <pvoronkin@...>
Date: 2018-12-04T07:11:42Z
IGNITE-10511 removeExplicitNodeLocks() removed.
----
> disco-event-worker can be deadlocked by BinaryContext.metadata running is sys
> striped pool waiting for cache entry lock
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-10511
> URL: https://issues.apache.org/jira/browse/IGNITE-10511
> Project: Ignite
> Issue Type: Bug
> Reporter: Pavel Voronkin
> Priority: Major
> Attachments: race.txt
>
>
> See attached thread dump:
> disco-event-worker hangs on removeExplicitNodeLocks() on GridCacheMapEntry
> which is held by GridDistributedTxRemoteAdapter acquired in
> GridCacheMapEntry.innerSet().
> CacheObjectBinaryProcessorImpl is waiting on metadata message on discovery,
> which can be processed due to disco-event-worker is stuck.
> Possible fix:
> {code:java}
> public void onNodeLeft(final ClusterNode node) {
> if (isDone() || !enterBusy())
> return;
> cctx.mvcc().removeExplicitNodeLocks(node.id(), initialVersion());
> try {
> onDiscoveryEvent(new IgniteRunnable() {
> @Override public void run() {
> if (isDone() || !enterBusy())
> return;
>
> ...
> }
> });
> }
> finally {
> ...
> }
> }
> {code}
> As we can see most of the processing is done async in IgniteRunnable() in
> exchange-worker.
>
> We can move
> {code:java}
> cctx.mvcc().removeExplicitNodeLocks(node.id(), initialVersion());
> {code}
> inside this Runnable's body.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
