[
https://issues.apache.org/jira/browse/IGNITE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709385#comment-16709385
]
Dmitriy Govorukhin commented on IGNITE-9023:
--------------------------------------------
[~daradurvs] I did review your change and I have a small question and remarks.
questions:
# Why do you use a custom topic? Can we do a test with standard P2P topic?
# Why test was added in kernel test suite but not in p2p?
remarks:
# Use static IP finder instead multicast (by default)
# Add dot at the end of string comments
# Some line is very long, and do not fit into the page
# I suggest use GridFutureAdapter instead CompletableFuture, in your test your
future return status boolean (true/false) but false is never used, so I suggest
change future and leave 2 states, done or exception
> LinkageError or ClassNotFoundException should not be swollen by
> GridDeploymentCommunication during processing deployment request.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-9023
> URL: https://issues.apache.org/jira/browse/IGNITE-9023
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.5
> Reporter: Ivan Daschinskiy
> Assignee: Vyacheslav Daradur
> Priority: Minor
> Fix For: 2.8
>
>
> In current implementation any error, that is thrown in
> GridDeploymentCommunication#processResourceRequest, is ignored silently.
> Any error should be logged and send to client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
