[
https://issues.apache.org/jira/browse/IGNITE-10203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711118#comment-16711118
]
ASF GitHub Bot commented on IGNITE-10203:
-----------------------------------------
SomeFire commented on a change in pull request #90: IGNITE-10203 Fix TC Bot
visa on Jira
URL: https://github.com/apache/ignite-teamcity-bot/pull/90#discussion_r239358963
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##########
@@ -394,8 +398,18 @@ String branchForTcB(String prId) {
ITeamcityIgnited teamcity = teamcityIgnitedProvider.server(srvId,
prov);
+ StringBuilder buildTypeId = new StringBuilder();
+
+ HelperConfig.getTrackedBranches().get(DEFAULT_TRACKED_BRANCH_NAME)
+ .ifPresent(b -> b.getChainsStream().filter(c ->
c.branchForRest.equals(ITeamcity.DEFAULT))
+ .findFirst().ifPresent(ch -> buildTypeId.append(ch.suiteId)));
+
+ BuildTypeCompacted suite =
teamcity.getBuildType(buildTypeId.toString());
Review comment:
Rename `suite` to `buildType`, `compositeBuildTypes` to
`compositeBuildTypeIds`, `buildType` to `btId`. Don't forget to check string
lengths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [TC Bot] Support for alternative configurations for PR testing
> --------------------------------------------------------------
>
> Key: IGNITE-10203
> URL: https://issues.apache.org/jira/browse/IGNITE-10203
> Project: Ignite
> Issue Type: Task
> Reporter: Nikolai Kulagin
> Assignee: Nikolai Kulagin
> Priority: Major
>
> Support for alternative configurations for PR testing (for example,
> IgniteTests24Java8_RunMl)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
