[
https://issues.apache.org/jira/browse/IGNITE-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712865#comment-16712865
]
Aleksey Plekhanov commented on IGNITE-9303:
-------------------------------------------
[~ilantukh], if we don't check WAL record pageId tag in tracker anymore, we
also can do some cleanup and delete code, which was written to check this tag:
{code:java}
// Set new fullPageId after recycle or after new page init, because pageId tag
is changed.
if (record instanceof RecycleRecord)
page.fullPageId(new FullPageId(((RecycleRecord)record).newPageId(), grpId));
else if (record instanceof InitNewPageRecord)
page.fullPageId(new FullPageId(((InitNewPageRecord)record).newPageId(),
grpId));
{code}
and:
{code:java}
page.fullPageId(fullPageId);
{code}
In {{applyWalRecord}} method.
> PageSnapshot can contain wrong pageId tag when not dirty page is recycling
> --------------------------------------------------------------------------
>
> Key: IGNITE-9303
> URL: https://issues.apache.org/jira/browse/IGNITE-9303
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.6
> Reporter: Aleksey Plekhanov
> Assignee: Ilya Lantukh
> Priority: Major
> Fix For: 2.8
>
>
> When page is recycling (for example in {{BPlusTree.Remove#freePage()}} ->
> {{DataStructure#recyclePage()}}) tag of {{pageId}} is modified, but original
> {{pageId}} is passed to {{writeUnlock()}} method and this passed {{pageId}}
> is stored to PageSnapshot WAL record.
> This bug may lead to errors in WAL applying during crash recovery.
> Reproducer (ignite-indexing module must be in classpath):
> {code:java}
> public class WalFailReproducer extends AbstractWalDeltaConsistencyTest {
> @Override protected boolean checkPagesOnCheckpoint() {
> return true;
> }
> public final void testPutRemoveCacheDestroy() throws Exception {
> CacheConfiguration<Integer, Integer> ccfg = new
> CacheConfiguration<>("cache0");
> ccfg.setIndexedTypes(Integer.class, Integer.class);
> IgniteEx ignite = startGrid(0);
> ignite.cluster().active(true);
> IgniteCache<Integer, Integer> cache0 = ignite.getOrCreateCache(ccfg);
> for (int i = 0; i < 5_000; i++)
> cache0.put(i, i);
> forceCheckpoint();
> for (int i = 1_000; i < 4_000; i++)
> cache0.remove(i);
> forceCheckpoint();
> stopAllGrids();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
