[ 
https://issues.apache.org/jira/browse/IGNITE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712920#comment-16712920
 ] 

Roman Kondakov commented on IGNITE-10462:
-----------------------------------------

[~amashenkov], there is a couple comments concerning this patch:

1. I guess a {{TRANSACTIONAL}} mode should be checked in this test by default: 
{{IgniteWalReaderTest#testRemoveOperationPresentedForDataEntry}}

2. There is no MVCC cache is started during these tests. I think 
{{setAtomicityMode(TRANSACTIONAL)}} should be set explicitly in the cache 
configuration to check both MVCC and non-MVCC cases. 
 * {{IgnitePdsPartitionFilesDestroyTest}}
 * {{IgniteNodeStoppedDuringDisableWALTest}}
 * {{IgnitePdsPartitionsStateRecoveryTest}}
 * {{IgnitePdsRebalancingOnNotStableTopologyTest}}
 * {{IgnitePdsWholeClusterRestartTest}}
 * {{IgniteRebalanceScheduleResendPartitionsTest}}
 * {{LocalWacModeNoChangeDuringRebalanceOnNonNodeAssignTest}} - there is also a 
misprint here. I guess it should be LocalWal... here.
 * {{LocalWalModeChangeDuringRebalancingSelfTest}}
 * {{SlowHistoricalRebalanceSmallHistoryTest}}
 * {{WalDeletionArchiveFsyncTest}}
 * {{WalDeletionArchiveLogOnlyTest}}

3. Empty lines before and after {{break}} statement  in 
{{IgniteWalReaderTest.java:1360}}

> MVCC: Create "PDS 2" test suite for MVCC mode.
> ----------------------------------------------
>
>                 Key: IGNITE-10462
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10462
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: mvcc
>            Reporter: Andrew Mashenkov
>            Assignee: Andrew Mashenkov
>            Priority: Major
>             Fix For: 2.8
>
>
> Create MVCC version of IgnitePdsTestSuite2 and add it to TC.
> All non-relevant tests should be marked as ignored.
>  Failed tests should be muted and tickets should be created for unknown 
> failure reasons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to