[
https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713879#comment-16713879
]
Oleg Ignatenko edited comment on IGNITE-10177 at 12/10/18 6:22 AM:
-------------------------------------------------------------------
(i) notes on some bullet points
plan in the description once had a bullet point about reviewing {{import
org.junit}} and possible removal. Upon closer study this turned a poor idea,
these should be left alone, primarily because importing asserts is done best
from {{org.junit.Assert}}
wrt {{WalCompactionTest}}, see IGNITE-10614
wrt {{IgnitePdsContinuousRestartTest}} the fix was to make one of its two
constructors protected instead of public, which left it with exactly one public
constructor, as required by JUnit 4
was (Author: oignatenko):
plan in the description once had a bullet point about reviewing {{import
org.junit}} and possible removal. Upon closer study this turned a poor idea,
these should be left alone, primarily because importing asserts is done best
from {{org.junit.Assert}}
> cleanup Junit 3 from the project
> --------------------------------
>
> Key: IGNITE-10177
> URL: https://issues.apache.org/jira/browse/IGNITE-10177
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Oleg Ignatenko
> Assignee: Oleg Ignatenko
> Priority: Major
>
> If needed, refer parent task for more details.
> # remove Junit3-specific parts of API of GridAbstractTest and its subclasses
> # remove dependencies from Junit 3 in Maven (if there are any)
> # migrate tests that were missed at prior steps, if there are any
> ## untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass
> which currently conflict with Junit4 execution because of using constructors
> and make them properly use {{@Test}} annotation
> ## find out why
> {{WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync}} appears to
> start running slow / timing out after adding Junit 4 annotations (reproduced
> this on teamcity and locally as was discovered in IGNITE-10175)
> # remove redundant references to {{JUnit4.class}} if there are any (like in
> {{@RunWith(JUnit4.class)}})
> # in tests suite classes, change {{extends TestSuite}} to either
> {{@RunWith(AllTests.class)}} or {{@Suite.SuiteClasses}}
> # find and update all Junit3-specific code that {{extends TestCase}}
> # execute junit related inspections of IDE and analyse results
> Side note if for some reason it turns out critically important to keep test
> suites names (by default Junit 4 will use suite class names instead),
> approach with custom description annotation [described
> here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
> can be used to address that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
