[ 
https://issues.apache.org/jira/browse/IGNITE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714875#comment-16714875
 ] 

Pavel Voronkin commented on IGNITE-10300:
-----------------------------------------

[~agoncharuk] we have common handling of such error here:

catch (Throwable e) {
 if (isAuthError(e))
 return error(ERR_AUTHENTICATION_FAILED, "Authentication error.", e);

 if (isConnectionError(e))
 return error(EXIT_CODE_CONNECTION_FAILED, "Connection to cluster failed.", e);

 return error(EXIT_CODE_UNEXPECTED_ERROR, "", e);
}

it will be covered by if (isAuthError(e)) condition.

IMHO throwing exception in 2561, will be clearer than handling it on our own.

 

 

> control.sh: incorrect error message after three tries on unsuccessful 
> authorization.
> ------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10300
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10300
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Pavel Voronkin
>            Assignee: Pavel Voronkin
>            Priority: Major
>             Fix For: 2.8
>
>
> 1. start grid with securirty enabled
> 2. try to issue control.sh --cache
> authentication credentials asked
> 3. enter incorrect credentials three times
> expected: Authentication error printed and logged
> actual: Latest topology update failed error printed
> {noformat}
> IGNITE_HOME=`pwd` bin/control.sh --cache list .
> Control utility [ver. 2.5.1-p160#20181113-sha1:5f845ca7]
> 2018 Copyright(C) Apache Software Foundation
> User: mshonichev
> --------------------------------------------------------------------------------
> Authentication error, try connection again.
> user: 
> password: 
> Authentication error, try connection again.
> user: 
> password: 
> Authentication error, try connection again.
> user: 
> password: 
> Authentication error.
> Error: Latest topology update failed.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to