[
https://issues.apache.org/jira/browse/IGNITE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716628#comment-16716628
]
Dmitriy Govorukhin commented on IGNITE-10446:
---------------------------------------------
[~v.pyatkov] I reviewed your changes, and I have several comments:
1. IdleVerifyResultV2:72-73 missed /** \{@inheritDoc} */
2. IdleVerifyResultV2:192 No need an empty line here
3. VerifyBackupPartitionsDumpTask:125 @Override should be inlined with method
declaration and /** \{@inheritDoc} */ missed
4. GridCommandHandlerTest.testCacheIdleVerifyDumpOnUnstableTopology
line 1090 - No need cast class to IgniteEx, нou don't use any ex methods.
line 1096 - You don't use parts variable, declare not required
line 1103-1104 Use IgniteDataStreamer instead single put
line 1106 - Why are you sure that we always will be sent a response to the node
with idx 0?
line 1115 - use waitForBlocked instead waitForBlocked(1)
Also, please add with a multi-node failed test.
> control.sh --cache idle_verify fail with NPE when node left grid
> ----------------------------------------------------------------
>
> Key: IGNITE-10446
> URL: https://issues.apache.org/jira/browse/IGNITE-10446
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 2.7
> Reporter: ARomantsov
> Assignee: Vladislav Pyatkov
> Priority: Critical
> Fix For: 2.8
>
>
> --------------------------------------------------------------------------------
> Command [IDLE_VERIFY -host=***] started at [2018-11-28 15:54:23]...
> Error code: 13000. java.lang.NullPointerException.
> Command [IDLE_VERIFY] failed with error: 13000 - command failed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
