[
https://issues.apache.org/jira/browse/IGNITE-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720236#comment-16720236
]
Ilya Kasnacheev commented on IGNITE-9893:
-----------------------------------------
Hello [~scottmf].
Thank you for the huge amount of work that you have performed!
There are several things I will ask you to do so that we can merge this new
module:
- Please rename Ignite*Hibernate5TestSuite to e.g. Ignite*Hibernate53TestSuite.
This is required so that we can easily differentiate between them on our
Teamcity.
- Please rebase your commit on top of master branch, and fix compilation errors
(DFLT_CACHE_NAME_PROPERTY is unavailable, which is used by hibernate-4.2
module).
- Please avoid reformatting code that you edit. We have extensive coding
guidelines:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines - in
short, please avoid removing blank lines between everything, please avoid
putting curly braces around single statements, please keep single level of
indentation, even for method parameters. Note that I can try to do that for you.
After that is done we'll do a TC run, I'll fix the remaining minor issues if
there are any, and merge to master.
> add hibernate-5.3 module
> ------------------------
>
> Key: IGNITE-9893
> URL: https://issues.apache.org/jira/browse/IGNITE-9893
> Project: Ignite
> Issue Type: New Feature
> Components: hibernate
> Reporter: Scott Feldstein
> Assignee: Scott Feldstein
> Priority: Major
>
> hi,
> I have ported hibernate-5.2 to ignite 2.7.0-SNAPSHOT HEAD.
> commit:
> [https://github.com/scottmf/ignite/commit/4f2caafb8c433e3f840d14f91c2d83da1052afd9]
> All tests pass except
> CacheHibernateBlobStoreSelfTest.testSimpleMultithreading which is carryover
> from the hibernate-5.1 implementation. There is a bug already associated with
> the failure:
> https://issues.apache.org/jira/browse/IGNITE-1757
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
