[ 
https://issues.apache.org/jira/browse/IGNITE-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721537#comment-16721537
 ] 

Ignite TC Bot commented on IGNITE-8558:
---------------------------------------

{panel:title=--> Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC Queries{color} [[tests 
8|https://ci.ignite.apache.org/viewLog.html?buildId=2546592]]
* IgniteCacheMvccSqlTestSuite: 
CacheMvccReplicatedSqlQueriesTest.testAccountsTxSql_ClientServer_Backups2 - 
0,0% fails in last 402 master runs.

{color:#d04437}ZooKeeper (Discovery) 1{color} [[tests 
8|https://ci.ignite.apache.org/viewLog.html?buildId=2546581]]
* ZookeeperDiscoverySpiTestSuite1: 
ZookeeperDiscoverySpiTest.testCustomEventsSimple1_SingleNode - 0,0% fails in 
last 406 master runs.

{color:#d04437}Continuous Query 1{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=2546553]]
* IgniteCacheQuerySelfTestSuite3: 
CacheContinuousWithTransformerPartitionedSelfTest.testContinuousWithTransformerAndRegularListenerKeepBinaryAsync
 - 0,0% fails in last 0 master runs.

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2546642&buildTypeId=IgniteTests24Java8_RunAll]

> Provide an opportunity to stop grids and cancel tasks after execution all 
> tests
> -------------------------------------------------------------------------------
>
>                 Key: IGNITE-8558
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8558
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 2.6
>            Reporter: Maxim Muzafarov
>            Assignee: Rodion
>            Priority: Minor
>             Fix For: 2.8
>
>
> The -IGNITE-6842- issue provides an ability gracefully shutdown all ignite 
> instances by default after execution of tests. Ignite instances are stopped 
> by calling the method - {{stopAllGrids}} ({{cancel = false}} is used). You 
> can refer to these lines of code for the details of how the node stopped:
> {code:java|title=GridAbstractTest.java:1789}
>  if (isSafeTopology()) {
>      stopAllGrids(false);
>      if (stopGridErr) {
>          err = new RuntimeException("Not all Ignite instances has been 
> stopped. " +
>              "Please, see log for details.", err);
>      }
>  }
> {code}
> As part of IGNITE-8266 a lot of boilerplate code have been successfully 
> removed. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
>     super.afterTestsStopped();
>     stopAllGrids();
> }
> {code}
> We need to,
>  * Provide the ability to override the behaviour of gracefully instance 
> shutdown and use {{stopAllGirds(true)}} after all tests execution. Assume a 
> new method would be introduced like {{GridAbstractTest#isSafeTopology}}, so 
> the behaviour can be overridden in subclasses.
>  * Remove the other boilerplate parts of the code. For instance,
> {code:java}
> /** {@inheritDoc} */
> @Override protected void afterTestsStopped() throws Exception {
>     stopAllGrids(true);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to