[
https://issues.apache.org/jira/browse/IGNITE-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vyacheslav Daradur updated IGNITE-10705:
----------------------------------------
Description:
Found that method {{IgniteConfigVariationsAbstractTest#isCompatible}} works
incorrectly.
Here is the actual code:
{code:java}
protected boolean isCompatible() throws Exception {
switch (dataMode) {
case BINARILIZABLE:
case PLANE_OBJECT:
return !(getConfiguration().getMarshaller() instanceof
JdkMarshaller);
}
return false;
}
{code}
It returns {{false}} if a test mode is [SERIALIZABLE, CUSTOM_SERIALIZABLE,
EXTERNALIZABLE], but they are main modes which are supported by any marshaller.
*That means a set of tests which should be executed will be skipped instead.*
Also, modes {{BINARILIZABLE}} and {{PLANE_OBJECT}} are supported only by
{{BinaryMarshaller}} and {{OptimizedMarshaller.setRequireSerializable(false)}}
was:
Found that method {{IgniteConfigVariationsAbstractTest#isCompatible}} works
incorrectly.
Here is the actual code:
{code:java}
protected boolean isCompatible() throws Exception {
switch (dataMode) {
case BINARILIZABLE:
case PLANE_OBJECT:
return !(getConfiguration().getMarshaller() instanceof
JdkMarshaller);
}
return false;
}
{code}
It returns {{false}} if a test mode is [SERIALIZABLE, CUSTOM_SERIALIZABLE,
EXTERNALIZABLE], but this is main modes which are supported by any marshaller.
*That means a set of tests which should be executed will be skipped instead.*
Also, modes {{BINARILIZABLE}} and {{PLANE_OBJECT}} are supported only by
{{BinaryMarshaller}} and {{OptimizedMarshaller.setRequireSerializable(false)}}
> Wrong check of test's compatible 'dataMode' in
> IgniteConfigVariationsAbstractTest
> ---------------------------------------------------------------------------------
>
> Key: IGNITE-10705
> URL: https://issues.apache.org/jira/browse/IGNITE-10705
> Project: Ignite
> Issue Type: Bug
> Reporter: Vyacheslav Daradur
> Priority: Major
>
> Found that method {{IgniteConfigVariationsAbstractTest#isCompatible}} works
> incorrectly.
> Here is the actual code:
> {code:java}
> protected boolean isCompatible() throws Exception {
> switch (dataMode) {
> case BINARILIZABLE:
> case PLANE_OBJECT:
> return !(getConfiguration().getMarshaller() instanceof
> JdkMarshaller);
> }
> return false;
> }
> {code}
> It returns {{false}} if a test mode is [SERIALIZABLE, CUSTOM_SERIALIZABLE,
> EXTERNALIZABLE], but they are main modes which are supported by any
> marshaller.
> *That means a set of tests which should be executed will be skipped instead.*
> Also, modes {{BINARILIZABLE}} and {{PLANE_OBJECT}} are supported only by
> {{BinaryMarshaller}} and {{OptimizedMarshaller.setRequireSerializable(false)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
