[
https://issues.apache.org/jira/browse/IGNITE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725782#comment-16725782
]
ASF GitHub Bot commented on IGNITE-10748:
-----------------------------------------
GitHub user Mmuzaf opened a pull request:
https://github.com/apache/ignite/pull/5711
IGNITE-10748: remove dead code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mmuzaf/ignite ignite-10748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5711.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5711
----
commit a68991aee7a93d4fb68814ef2999bf953c964942
Author: Maxim Muzafarov <maxmuzaf@...>
Date: 2018-12-20T11:26:07Z
IGNITE-10748: remove dead code
----
> Remove dead code in TcpCommunicationSpi for the tcp client creation flow
> ------------------------------------------------------------------------
>
> Key: IGNITE-10748
> URL: https://issues.apache.org/jira/browse/IGNITE-10748
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Minor
> Fix For: 2.8
>
>
> Currently, a batch of changes can be applied over {{TcpCommunicationSpi}}
> class implementation due to:
> # {{safeTcpHandshake(..)}}
> #* {{handshakeConnIdx}} - parameter is always not null
> #* {{recovery}} - parameter is always not null
> #* {{HandhakeMessage}} - is not used in current flow at all
> # {{HandshakeMessage2}}
> #* Message size must be defined in the message class as constant
> # {{createTcpClient(..)}}
> #* Instantiation of {{GridTcpNioCommunicationClient}} must be performed
> outside the while-loop
> # Code-style issues
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
