[ 
https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726048#comment-16726048
 ] 

Ignite TC Bot commented on IGNITE-10177:
----------------------------------------

{panel:title=--> Run :: All (Nightly): No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All (Nightly)* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2595352&buildTypeId=IgniteTests24Java8_RunAllNightly]

> cleanup Junit 3 from the project
> --------------------------------
>
>                 Key: IGNITE-10177
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10177
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>
> If needed, refer parent task for more details.
>  # remove Junit3-specific parts of API of GridAbstractTest and its subclasses
>  # remove dependencies from Junit 3 in Maven (if there are any)
>  # migrate tests that were missed at prior steps for various reasons:
>  ## untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass 
> which currently conflict with Junit4 execution because of using constructors 
> and make them properly use {{@Test}} annotation
>  ## find out why 
> {{WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync}} appears to 
> start running slow / timing out after adding Junit 4 annotations (reproduced 
> this on teamcity and locally as was discovered in IGNITE-10175)
>  ## find out why {{IgniteTwitterStreamerTest}} runs fine under JUnit 3 but 
> starts failing after move to JUnit 4
>  ## IgniteCachePartitionedQuerySelfTest, 
> IgniteCacheReplicatedQueryP2PDisabledSelfTest, ComputeUtilsTest, 
> CacheBasedDatasetBuilderTest, CacheBasedDatasetTest, 
> GridPartitionedCacheJtaLookupClassNameSelfTest, 
> GridReplicatedCacheJtaLookupClassNameSelfTest (there were problems migrating 
> these at IGNITE-10176)
>  ## find out why tests in logging suite failed on teamcity (not locally) when 
> setup method was annotated {{@Before}}
>  ## (!) note part of this work related to 
> {{IgniteConfigVariationsAbstractTest}} is expected to be done separately per 
> IGNITE-10739
> # in tests suite classes, change {{extends TestSuite}} to either 
> {{@RunWith(AllTests.class)}} or {{@Suite.SuiteClasses}}
> # find and update all Junit3-specific code that {{extends TestCase}}
> # execute junit related inspections of IDE and analyse results
> # remove redundant references to {{JUnit4.class}} if there are any (like in 
> {{@RunWith(JUnit4.class)}})
>   (i) per discussion with [~EdShangGG] plan to to do this in a separate 
> ticket for smoother merges - IGNITE-10758
> Side note if for some reason it turns out critically important to keep test 
> suites names (by default Junit 4 will use suite class names instead), 
> approach with custom description annotation [described 
> here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
>  can be used to address that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to