[
https://issues.apache.org/jira/browse/IGNITE-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728735#comment-16728735
]
Alexey Goncharuk commented on IGNITE-9607:
------------------------------------------
[~daradurvs], a few minor comments:
1) Not sure if it was discussed with other community members, but I think it
may be better to get rid of various {{instanceof}} statements in the code and
have a common interface for both service processor implementations (possibly,
noop)
2) Should we narrow down the generic type of {{ServiceDeploymentFuture}} to
{{Serializable}}?
3) In {{IgniteServiceProcessor#stopProcessor()}} we need to wrap
{{fut.onDone(stopError)}} in a try-catch block. We recently discovered that
{{onDone()}} call can re-throw the exception to the caller, which prevents
correct node stop
4) I think we should add (maybe in a separate ticket) some diagnostic mechanics
to dump pending deployment futures. The best option is to use existing PME
diagnostic mechanics
> Service Grid redesign - phase 1
> -------------------------------
>
> Key: IGNITE-9607
> URL: https://issues.apache.org/jira/browse/IGNITE-9607
> Project: Ignite
> Issue Type: Improvement
> Components: managed services
> Reporter: Vyacheslav Daradur
> Assignee: Vyacheslav Daradur
> Priority: Major
> Fix For: 2.8
>
>
> This is an umbrella ticket for tasks which should be implemented atomically
> in phase #1 of Service Grid redesign.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
