[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728789#comment-16728789
]
ASF GitHub Bot commented on IGNITE-10178:
-----------------------------------------
GitHub user ololo3000 opened a pull request:
https://github.com/apache/ignite/pull/5745
IGNITE-10178 Ignore annotations added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ololo3000/ignite IGNITE-10178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5745
----
commit aa2c91f0de000323e1ab8246ae5a1d55429f16d1
Author: Petrov <pmgheap.sbt@...>
Date: 2018-12-25T15:05:58Z
IGNITE-10178 Ignore annotations added
commit 8b859ace05cbe0e20a5f7a13be32fa0179591728
Author: Petrov <pmgheap.sbt@...>
Date: 2018-12-25T15:12:18Z
Merge branch 'master' into IGNITE-10178
commit 1a8cc8fe1251b1ced6e278816c7ad4ac1c4ecbe7
Author: Petrov <pmgheap.sbt@...>
Date: 2018-12-25T16:56:58Z
IGNITE-10178 minor fixes
----
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -------------------------------------------------------------------------------------
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Oleg Ignatenko
> Assignee: PetrovMikhail
> Priority: Major
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them.
> -----
> Note that tests that are expected to be ignored depending on runtime
> conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that
> old code...
> {code}if (someRuntimeCondition())
> fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL",
> someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more
> convenient). Readers interested to find more details about how {{Assume}}
> works can find more details and code snippet [in comments
> here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
