[ https://issues.apache.org/jira/browse/IGNITE-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729463#comment-16729463 ]
ASF GitHub Bot commented on IGNITE-10827: ----------------------------------------- GitHub user ygerzhedovich opened a pull request: https://github.com/apache/ignite/pull/5758 IGNITE-10827 …been read You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10827 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5758.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5758 ---- commit a06abb2c80b883fc0c94027dcee8c74748584883 Author: Yury Gerzhedovich <ygerzhedovich@...> Date: 2018-12-27T09:13:28Z IGNITE-10827: auto close iterator for query cursor when all data has been read ---- > auto close iterator for query cursor when all data has been read > ---------------------------------------------------------------- > > Key: IGNITE-10827 > URL: https://issues.apache.org/jira/browse/IGNITE-10827 > Project: Ignite > Issue Type: Task > Components: sql > Reporter: Yury Gerzhedovich > Assignee: Yury Gerzhedovich > Priority: Major > Labels: sql > > There is QueryCursorImpl class which we use as main realization of cursor for > H2 iterators. As of now we call close method explicit when we suppose that > all data already read. Will be better call close() method when iterator > hasNext() method return false or when next() method of iterator throw any > Exception. Such realization will be more safely and simple to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)