[ 
https://issues.apache.org/jira/browse/IGNITE-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738221#comment-16738221
 ] 

Yury Gerzhedovich commented on IGNITE-10754:
--------------------------------------------

[~vozerov], thanks for the review. 
 # Ok. However it looks strange for me to have two similar separate API. Return 
back old classes without deprecated annotation.
 # Ok.
 # Due to it was moved into RunningQueryManager it's already so.
 # Ok.
 # Ok.
 # Fixed.
 # Fixed.
 # It cover case when query will be added again after evict between insert into 
map and insert into queue . In this case we should remove node which can be 
duplicate for concurrently added query stats.
 # Usually it's just a investigation running and we can push out real queries. 
It it really required to track EXPLAIN queries?
 # I use queue to keep right order of queries. You are right about duplicates 
for current realization. Also, any case we can have duplicates if will not use 
intermediate collections due to the same query can be evicted and added again 
under high load. Will rewrite it.
 # Could you please clarify it. I don't see not SQL here.
 # Agree. fixed.

> Query history statistics API
> ----------------------------
>
>                 Key: IGNITE-10754
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10754
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Yury Gerzhedovich
>            Assignee: Yury Gerzhedovich
>            Priority: Major
>              Labels: iep-29, monitoring
>
> As of now we have query statistics 
> (*_org.apache.ignite.IgniteCache#queryMetrics_*) , but have few issues.
> 1) Duration execution it just time between start execution and return cursor 
> to client and doesn't include all life time of query.
> 2) It doesn't know about multistatement queries. Such queries participate in 
> statistics as single query without splitting.
> 3) API to access the statistics expose as depend on cache, however query 
> don't have such dependency.
>  
> Need to create parallel similar realization as we already have.
> Use new infrastructure of tracking running queries developed under 
> IGNITE-10621 and update statistics on unregister phase.
> Expose API on upper level then it placed now. Right place will be written 
> later.
>  
> Old API will be marked as deprecated.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to