[ 
https://issues.apache.org/jira/browse/IGNITE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746506#comment-16746506
 ] 

Mikhail Cherkasov commented on IGNITE-10944:
--------------------------------------------

Ignite already has method validateNode(ClusterNode node, 
JoiningNodeDiscoveryData discoData)  in GridPlugingComponent, we just need to 
make ignite use this method and bypass discoData to plugin provider.

I added a new method to plugins provider to implement this and added default 
implementation to interface to keep compatibility with existing plugins:

[https://github.com/apache/ignite/pull/5865/files]

 

[~agoncharuk] could you please review my changes?

> Plugin discovery data from PluginProvider.provideDiscoveryData should be 
> available in PluginProvider.validateNewNode
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10944
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10944
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.7
>            Reporter: Andrey Aleksandrov
>            Assignee: Mikhail Cherkasov
>            Priority: Major
>             Fix For: 2.8
>
>
> *Current  sequence:*
>  
> 1)Server starts (coordinator)
> 2)Client starts
> 3)Client sends to the coordinator its discovery data using 
> *provideDiscoveryData* method
> 4)Coordinator start validation of the node using *validateNewNode*
> 5)The client joins the cluster; otherwise fails
> 6)Coordinator provides the discovery data to plugin provider in 
> *receiveDiscoveryData.* After that this data could be passed to the plugin.
> But in case if we require to validate new node using the discovery data from 
> *receiveDiscoveryData* method then we should add a possibility to get this 
> data in *validateNewNode* method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to