[
https://issues.apache.org/jira/browse/IGNITE-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747402#comment-16747402
]
Vladimir Ozerov commented on IGNITE-10754:
------------------------------------------
[~jooger], implementation still doesn't look correct to me.
# First question is why we return {{RunningQueryManager.register}} returns
{{GridRunningQueryInfo}}, while in reality {{Long}} iD is enough, as nothing
else from {{GridRunningQueryInfo}} is used anywhere.
# Why {{RunningQueryManager.unregister}} methods are not void? Their results
are not used anywhere.
# {{RunningQueryManager.unregister}} - when {{run,remove}} is called,
subsequent call to query history tracker do not perform {{null}} check. As a
result, one may get NPE in {{close}} is called several times on some cursor.
> Query history statistics API
> ----------------------------
>
> Key: IGNITE-10754
> URL: https://issues.apache.org/jira/browse/IGNITE-10754
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Yury Gerzhedovich
> Assignee: Yury Gerzhedovich
> Priority: Major
> Labels: iep-29, monitoring
> Fix For: 2.8
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As of now we have query statistics
> (*_org.apache.ignite.IgniteCache#queryMetrics_*) , but have few issues.
> 1) Duration execution it just time between start execution and return cursor
> to client and doesn't include all life time of query.
> 2) It doesn't know about multistatement queries. Such queries participate in
> statistics as single query without splitting.
> 3) API to access the statistics expose as depend on cache, however query
> don't have such dependency.
>
> Need to create parallel similar realization as we already have.
> Use new infrastructure of tracking running queries developed under
> IGNITE-10621 and update statistics on unregister phase.
> Expose API on upper level then it placed now. Right place will be written
> later.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
