[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750401#comment-16750401
]
Pavel Tupitsyn commented on IGNITE-7128:
----------------------------------------
[~lkhenkin]
{{CheckpointBufferPages}} is a public property on public interface, and thus is
a part of our public API.
Imagine you have a code base that uses this property somewhere to show metrics.
Now we remove it and release a new Ignite version. You update NuGet package and
your code no longer compiles. We don't break compatibility like this in minor
releases (2.x). Breaking changes can be introduced when we decide to release
next major version (3.0).
Yes, there was a mistake on Java side
([commit|https://github.com/apache/ignite/commit/86c18998dbb430c69eb136ffce54858f52432808]),
they removed public property and have broken the compatibility.
The right way to do this is to mark the property with {{ObsoleteAttribute}}
({{deprecated}} annotation in Java). Then as part of a major release we go over
deprecated parts and remove them.
*To summarize, please do the following:*
* Mark {{CheckpointBufferPages}} with {{[Obsolete]}}. Return 0 from there and
update XMLDoc to explain the situation
* Keep everything else as is (add new {{UsedCheckpointBufferPages}} property
instead of renaming old one)
Makes sense?
P.S. This issue with wrong properties is a very good catch, thank you! I've
notified my colleagues about the breakage on Java side.
> .NET: Add missing DataRegionMetrics
> -----------------------------------
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Reporter: Pavel Tupitsyn
> Assignee: Lev Khenkin
> Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
