[
https://issues.apache.org/jira/browse/IGNITE-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755860#comment-16755860
]
Oleg Ignatenko commented on IGNITE-10179:
-----------------------------------------
[~Pavlukhin] thanks for your comments! I just corrected Void (should be void
indeed) and typo invokation -> invocation and pushed these fixes to branch.
As for repeated calls of skipIfNotSupported, per my testing it appeared as
necessary. If memory serves I first tried at @Before because it looked like a
natural place for it. However some tests started failing when I did it this way
and by debugging I discovered that it checking in getConfiguration fixes these
failures so I moved it there but then again, some other tests started failing
because of that and I recovered it in Before and got all tests pass.
For the sake of completeness I also briefly tried if I could find a simpler way
that would invoke skipIfNotSupported from some single place but it turned out
that tests have somewhat clumsy inheritance relationship that makes it
difficult to find such a place, at least without making substantial changes in
the tests. At this point I dropped that idea and have chosen to keep repeat
invocations because it looked safer than messing with test code.
> Change new tests root to use @BeforeClass and @AfterClass instead of
> isFirstTest() and isLastTest()
> ---------------------------------------------------------------------------------------------------
>
> Key: IGNITE-10179
> URL: https://issues.apache.org/jira/browse/IGNITE-10179
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Oleg Ignatenko
> Assignee: Oleg Ignatenko
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If needed, refer parent task for more details.
> isFirstTest() and isLastTest() homebrew methods seem to be in
> GridAbstractTest only because Junit 3 lacked necessary functionality; after
> migration to Junit 4 these would better changed to use standard API of this
> framework.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
