[
https://issues.apache.org/jira/browse/IGNITE-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756034#comment-16756034
]
Igor Seliverstov commented on IGNITE-10976:
-------------------------------------------
[~amashenkov], see my comments below:
1) DmlStatementsProcessor#toSqlException since IgniteSQLException is a part of
ignite-core and SQLException is a part of java runtime it's OK to move this
method to IgniteUtils (where we do exception conversions)
2) DmlStatementsProcessor.java:660 seems it's already done in
IgniteUtils.convertException(..) let's use IgniteUtils instead
3) GridCacheDistributedQueryFuture.java:152 Is it OK we use
ClusterTopologyException instead of ClusterTopologyCheckedException? I'm not
sure we don't break remap logic by this change.
4) GridCacheUtils.java:1318 I think it should be done by exception conversion
that is being done below.
5) IgniteCacheMessageRecoveryIdleConnectionTest#beforeTestsStarted Destroying
cache before a test looks quite tricky
> MVCC: Sql API methods should throws proper TransactionExceptions in case of
> tx failure.
> ---------------------------------------------------------------------------------------
>
> Key: IGNITE-10976
> URL: https://issues.apache.org/jira/browse/IGNITE-10976
> Project: Ignite
> Issue Type: Bug
> Components: mvcc, sql
> Reporter: Andrew Mashenkov
> Assignee: Andrew Mashenkov
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For now Sql API can throws SqlException (without any actual Tx failure cause)
> or TransactionException wrapped into CacheException.
> Also, I've found we convert unchecked exceptions into checked ones and then
> back without any obvious reason.
> Let's make TransactionException thows properly and add it to Sql Api contract.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
