[
https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771779#comment-16771779
]
Maxim Muzafarov commented on IGNITE-11277:
------------------------------------------
An example of the failed build if checkstyle rules have been violated:
https://ci.ignite.apache.org/viewLog.html?buildId=3123738&buildTypeId=IgniteTests24Java8_BuildApacheIgnite&tab=buildLog&branch_IgniteTests24Java8=pull%2F6134%2Fhead
{code}
[12:57:24] [Step 3/4] [INFO] Starting audit...
[12:57:24] [Step 3/4] [ERROR]
/data/teamcity/work/9198da4c51c3e112/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/IgniteDhtDemandedPartitionsMap.java:23:8:
Unused import - java.util.List. [UnusedImports]
[12:57:24] [Step 3/4] [ERROR]
/data/teamcity/work/9198da4c51c3e112/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/IgniteDhtDemandedPartitionsMap.java:37:1:
File contains tab characters (this is the first instance). [FileTabCharacter]
[12:57:24] [Step 3/4] Audit done.
[12:57:24] [Step 3/4] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (check-style) on
project ignite-core: Failed during checkstyle execution
[12:57:24] [Step 3/4] [INFO]
------------------------------------------------------------------------
[12:57:24] [Step 3/4] [INFO] Reactor Summary:
[12:57:24] [Step 3/4] [INFO]
[12:57:24] [Step 3/4] [INFO] ignite-apache-license-gen
.......................... SUCCESS [ 1.540 s]
[12:57:24] [Step 3/4] [INFO] ignite-tools
....................................... SUCCESS [ 22.872 s]
[12:57:24] [Step 3/4] [INFO] ignite-core
........................................ FAILURE [ 56.216 s]
[12:57:24] [Step 3/4] [INFO] ignite-compress
.................................... SKIPPED
[12:57:24] [Step 3/4] [INFO] ignite-indexing
.................................... SKIPPED
{code}
> Use maven plugin as default code style checker for project
> ----------------------------------------------------------
>
> Key: IGNITE-11277
> URL: https://issues.apache.org/jira/browse/IGNITE-11277
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: inspections
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough.
> The suite has a {{FAILED}} status for more than 2 months due to some issues
> on TeamCity application [2]. It confuses most of the members of the Apache
> Ignite community.
> Moreover, this suite is no longer checks configured rules. For instance, in
> the master branch, 11 {{Unused imports}} can be found (e.g. for
> {{IgniteCachePutAllRestartTest}
> [3]).
> I think the maven-checkstyle-plugin should be used as the default code style
> checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
