[ 
https://issues.apache.org/jira/browse/IGNITE-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791448#comment-16791448
 ] 

Vladimir Ozerov commented on IGNITE-10161:
------------------------------------------

[~jooger], my comments:
# {{SqlParserDropIndexSelfTest}} - exception is removed from signature, but 
JavaDoc is not fixed
# I am not sure there are tests for client disconnect. Do we have them?
# {{CommandProcessor.onDisconnected}} - error message is misleading, we do not 
know whether query was cancelled or not. I would rewrite it as "Failed to 
cancel query because local client node has been disconnected from the cluster"

Otherwise looks good.

> Be able to cancel any query by query id
> ---------------------------------------
>
>                 Key: IGNITE-10161
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10161
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Yury Gerzhedovich
>            Assignee: Yury Gerzhedovich
>            Priority: Major
>              Labels: iep-29
>             Fix For: 2.8
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> User should be able to cancel any query by query id through SQL command.
> SQL syntax: *KILL QUERY \{ASYNC} '<_query_id>'_*
> _ASYNC_ is optional parameter which return control immediately without 
> waiting real cancellation will be done.
> By default, without ASYNC parameter, the request is blocking untill 
> cancellation is not done.
> Query should be canceled  together with its parts on all nodes. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to