[
https://issues.apache.org/jira/browse/IGNITE-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791540#comment-16791540
]
Vladimir Ozerov commented on IGNITE-7664:
-----------------------------------------
[~tledkov-gridgain], please see my comments below. Looks good to me in general,
but some polishing is needed.
# {{SqlParser}} - "are not supported" -> "is not supported"
# {{QueryParser.parseNative}} - {{catch (IgniteSQLException e)}} block looks
incorrect. By the contract, if any parsing error occurrs, we should throw
{{IgniteSQLException}} with proper code. This block could be removed if correct
exception is thrown form parser, which is {{SqlStrictParseException}} in this
case
# {{GridSqlQueryParser.parseCreateTable}} - separate exception should be thrown
for any unsupported keyword with as simple error message as possible
("<something> keyword is not supported")
# {{GridSqlQueryParser.parseAddColumn}} - same as previous point. We should
throw highly specialized error messages for the sake of consistency with other
parsing logic.
> SQL: throw sane exception on unsupported SQL statements
> -------------------------------------------------------
>
> Key: IGNITE-7664
> URL: https://issues.apache.org/jira/browse/IGNITE-7664
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Alexander Paschenko
> Assignee: Taras Ledkov
> Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Inspired by this SO issue:
> [https://stackoverflow.com/questions/48708238/ignite-database-create-schema-assertionerror]
> We should handle unsupported stuff more gracefully both in core code and
> drivers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
