[ 
https://issues.apache.org/jira/browse/IGNITE-11135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797791#comment-16797791
 ] 

Ilya Borisov edited comment on IGNITE-11135 at 3/21/19 3:55 AM:
----------------------------------------------------------------

[~pkonstantinov] fixed.

What was happening:
Chart.js streaming plugin [explicitly formats label to 12h 
time|https://github.com/nagix/chartjs-plugin-streaming/blob/v1.7.1/src/scales/scale.realtime.js#L258]
 and does not provide any options to change this. To reformat the label, 
[~alexdel] decided to use `Date.parse`, but because all browsers parse 
non-standard date strings (which was the case) differently, the solution worked 
in Chrome (it managed to parse the value into proper Date) and failed in 
Firefox. After looking around streaming plugin source code I found what the 
actual moment-compatible string formats are and used those to parse the label. 
My solution does not rely on browser Date implementation details and should 
output the same value regardless of browser.

[~kuaw26] please review.


was (Author: klaster_1):
[~pkonstantinov] fixed.

What was happening:
Chart.js streaming plugin [explicitly formats label to 12h 
time|https://github.com/nagix/chartjs-plugin-streaming/blob/v1.7.1/src/scales/scale.realtime.js#L258]
 and does not provide any options to change this. To reformat the label, 
[~alexdel] decided to use `Date.parse`, but because all browsers parse 
non-standard date strings (which was the case) differently, the solution worked 
in Chrome (it managed to parse the value into proper Date) and failed in 
Firefox. After looking around streaming plugin source code I found what the 
actual moment-compatible string formats are and used those to parse the label. 
My solution does not rely on browser Date implementation details and should 
output the same value regardless of browser.

> Incorrect time format in the chart's tooltip
> --------------------------------------------
>
>                 Key: IGNITE-11135
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11135
>             Project: Ignite
>          Issue Type: Bug
>          Components: UI, wizards
>            Reporter: Alexander Kalinin
>            Assignee: Pavel Konstantinov
>            Priority: Minor
>             Fix For: 2.8
>
>   Original Estimate: 1h
>          Time Spent: 2.1h
>  Remaining Estimate: 0h
>
> X-axis has 24 hour format, but in the tooltip 12 hour format



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to