[ https://issues.apache.org/jira/browse/IGNITE-11411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800072#comment-16800072 ]
Ivan Fedotov edited comment on IGNITE-11411 at 3/24/19 1:52 PM: ---------------------------------------------------------------- [~Pavlukhin] , Thank you for your attention. I fixed merge conflicts and re-run TC nightly[1]. According to this, there are no blockers related to this ticket. I guess that now ticket is ready for the review again. By the way, I noticed that your changes in the ticket [2] have an influence on beforeTestsStarted(), afterTestsStarted() methods. I guess that now when we decided to leave the support of such methods in the context of JUnit rules, my ticket about removing of them [3] becomes not actual. If you do not mind, I will comment it with a link on your ticket and close as "Not a problem". [1] [https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAllNightly&branchForTc=pull/6227/head&action=Latest] [2]https://issues.apache.org/jira/browse/IGNITE-11356 [3] https://issues.apache.org/jira/browse/IGNITE-11413 was (Author: ivanan.fed): [~Pavlukhin] , Thank you for your attention. I fixed merge conflicts and re-run TC nightly[1]. According to this, there are no blockers related to this ticket. I guess that now ticket is ready for the review again. By the way, I noticed that your changes in the ticket [2] have an influence on beforeTestsStarted(), afterTestsStarted() methods. I guess that now when we decided to leave the support of such methods in the context of JUnit rules, my ticket about removing of them [3] becomes not actual. If you do not mind, I will comment it with a link on your ticket and close as "Not a problem". [1] [https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAllNightly&branchForTc=pull/6227/head&action=Latest] [2]https://issues.apache.org/jira/browse/IGNITE-11356 [3] https://issues.apache.org/jira/browse/IGNITE-11413 > Remove tearDown, setUp from JUnit3TestLegacySupport > --------------------------------------------------- > > Key: IGNITE-11411 > URL: https://issues.apache.org/jira/browse/IGNITE-11411 > Project: Ignite > Issue Type: Improvement > Reporter: Ivan Fedotov > Assignee: Ivan Fedotov > Priority: Major > Labels: iep-30 > Time Spent: 10m > Remaining Estimate: 0h > > TearDown and setUp methods are deprecated for JUnit 4+ version. It is > necessary to replace them with appropriate methods, marked by @Before and > @After annotations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)