[ https://issues.apache.org/jira/browse/IGNITE-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802852#comment-16802852 ]
Ivan Pavlukhin edited comment on IGNITE-11606 at 3/27/19 2:26 PM: ------------------------------------------------------------------ [~EdShangGG], a following code caught my attention {code} * @return False if index rebuild is meaningless. */ private boolean rebuildIsMeaningful(GridCacheContext cctx) { {code} It seems that method semantic is _rebuildIsMeaning{color:red}less{color}_ and it is better to indicate in what cases method returns {{true}} in javadoc. was (Author: pavlukhin): [~EdShangGG], a following code caught my attention {code} * @return False if index rebuild is meaningless. */ private boolean rebuildIsMeaningful(GridCacheContext cctx) { {code} It seems that method semantic is rebuildIsMeaning *less* and it is better to indicate in what cases method returns {{true}} in javadoc. > Index could not contain all values from cache after index full rebuild > ---------------------------------------------------------------------- > > Key: IGNITE-11606 > URL: https://issues.apache.org/jira/browse/IGNITE-11606 > Project: Ignite > Issue Type: Bug > Components: cache, persistence, sql > Reporter: Eduard Shangareev > Assignee: Eduard Shangareev > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > If index.bin was deleted, we would rebuild it on node start. > But it could cause to the situation when a key is in the cache but SQL query > doesn't return it. > {code} > [18:29:07][:363] idle_verify check has finished, found 1194 conflict > partitions: [counterConflicts=0, hashConflicts=1194] > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)