[
https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804039#comment-16804039
]
Sergey Antonov commented on IGNITE-10896:
-----------------------------------------
[~Denis Chudov]
1) We should check, that all regexps are correct, before sending task to
cluster.
2) I didn't find validation cache filter conditions for conflicts (i.e.
{{--caches cache1 --exclude-caches cache1 }}).
3) Please add tests for idle_verify command without {{--dump}} option.
4) Please add info about default values for cache filter options to help output
{{--cache help}}
5) We shouldn't throw exception if node not have matched caches. Sending
special task result (matched caches not found) looks better.
6) I got odd control.sh output in
{{testCacheIdleVerifyDumpMultipleOptionsFail()}}
{code:java}
Control utility [ver. 2.7.0-SNAPSHOT#20190328-sha1:DEV]
2019 Copyright(C) Apache Software Foundation
User: santonov
Time: 2019-03-28T18:24:18.794
--------------------------------------------------------------------------------
VisorIdleVerifyDumpTask successfully written output to
'C:\git\apache-ignite\work\idle-dump-2019-03-28T18-24-19_477.txt'
idle_verify failed on 2 nodes.
idle_verify check has finished, found 0 partitions
idle_verify task args were following: --cache-filter ALL --exclude-caches .*
{code}
User could be confused this message. Please fix it.
> Add ability to use simultaneous cache filtering options with control.sh
> --cache idle_verify
> -------------------------------------------------------------------------------------------
>
> Key: IGNITE-10896
> URL: https://issues.apache.org/jira/browse/IGNITE-10896
> Project: Ignite
> Issue Type: Improvement
> Reporter: ARomantsov
> Assignee: Denis Chudov
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now I can use only one of next options
> 1) --exclude-caches cache1,...,cacheN
> 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT
> 3) cache1,...,cacheN
> Trying to use two or more of this options currently results in error:
> {noformat}
> Error: Should use only one of option: --excludeCaches, --cache-filter or pass
> caches explicitly
> {noformat}
> Instead, utility should do the following:
> 1) when two or more options specified, result cache set to make dump of
> should be logical AND of results of each option applied individually.
> ex.
> {noformat}
> cache.* --cache-filter PERSISTENT
> {noformat}
> should select all persistent caches starting from 'cache'
> {noformat}
> --cache-filter ALL
> --exclude-caches wrong-.*-caches
> {noformat}
> should select all caches but matching 'wrong-.*-caches' regexp
> etc.
> 2) filtering options passed to control utility should be logged into result
> dump file, so that user could understand that dump was taken from subset of
> cluster caches
> 3) when result of filter or filters AND'ing is empty set of cache names,
> proper error message should be given and no dump file generated.
> e.g.
> {noformat}Error: can't find any cache matching cache names '--skup-zerus' and
> cache filter 'PERSISTENT', dump won't be generated.{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
