[
https://issues.apache.org/jira/browse/IGNITE-11666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821248#comment-16821248
]
Pavel Kuznetsov commented on IGNITE-11666:
------------------------------------------
[~isapego], In functional point, changes are ok.
Styling :
I see you removed redundant "ignite" namespace specification. Though I
personally prefer to use full namespaces (or typedefs), would you please make
other places "ignite::examples::" unified. Also
{{examples/include/ignite/examples/organization.h}} uses full namespace path as
well.
Where we can find doc, that tells us which functions we must to implement to
define binary format for the new struct?
Since it is an example I would leave comment or reference to the doc. Maybe
binary object example? Other example that explains BinaryType<> convention in
details? (Nice-to-have)
> C++ : remove macro usages in the examples
> -----------------------------------------
>
> Key: IGNITE-11666
> URL: https://issues.apache.org/jira/browse/IGNITE-11666
> Project: Ignite
> Issue Type: Improvement
> Components: examples, platforms
> Reporter: Pavel Kuznetsov
> Assignee: Igor Sapego
> Priority: Major
> Labels: c++, examples
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently c++ examples are using internal macros. For example to specify how
> to serialize/deserialize user's c++ structs.
> {code:c++}
> IGNITE_BINARY_TYPE_START(ignite::examples::Person)
> typedef ignite::examples::Person Person;
> IGNITE_BINARY_GET_TYPE_ID_AS_HASH(Person)
> IGNITE_BINARY_GET_TYPE_NAME_AS_IS(Person)
> IGNITE_BINARY_GET_FIELD_ID_AS_HASH
> IGNITE_BINARY_IS_NULL_FALSE(Person)
> IGNITE_BINARY_GET_NULL_DEFAULT_CTOR(Person)
> //...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
