[
https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824634#comment-16824634
]
Ivan Rakov commented on IGNITE-11512:
-------------------------------------
[~a-polyakov], some comments:
1) CacheGroupMetricsMXBean lacks @MXBeanDescription for new method (you can
override method like it's done in CacheMetricsMXBean).
2) Please put spaces around binary operator '='
{code:java}
metrics=new CacheGroupMetricsImpl();
{code}
3) Both places in code where you call "setIndexBuildCountPartitionsLeft" use
SchemaIndexCacheVisitorImpl. Can we move "setIndexBuildCountPartitionsLeft"
inside SchemaIndexCacheVisitorImpl to avoid code duplication?
4) Please add public modifier to
CacheGroupMetrics#getIndexBuildCountPartitionsLeft
5) CacheGroupMetricsImpl.java:26 - unnecessary blank line
6) Abbreviation plugin reports about "indexBuildCountPartitionsLeft" in
CacheGroupMetricsImpl and some field names in
CacheGroupMetricsMBeanWithIndexTest, please fix.
7) From my point of view, it would be better to move all logic from
CacheGroupMetricsMXBeanImpl to CacheGroupMetricsImpl
(CacheGroupMetricsMXBeanImpl would just delegate all method calls to
CacheGroupMetricsImpl). Advantages: we'll be able to unit-test cache group
metrics without registering MXBean, we'll be able to post metrics to another
metrics consumer without registering MXBean and so on. What do you think?
> Add counter left partition for index rebuild in CacheGroupMetricsMXBean
> -----------------------------------------------------------------------
>
> Key: IGNITE-11512
> URL: https://issues.apache.org/jira/browse/IGNITE-11512
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.7
> Reporter: Alexand Polyakov
> Assignee: Alexand Polyakov
> Priority: Major
>
> Now, if ran rebuild indexes, this can determined only on load CPU and thread
> dump. The presence of the "how many partitions left to index" metric will
> help determine whether the rebuilding is going on and on which cache, as well
> as the percentage of completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
