[ 
https://issues.apache.org/jira/browse/IGNITE-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825444#comment-16825444
 ] 

Pavel Kuznetsov commented on IGNITE-11470:
------------------------------------------

3.1) Discussable: Similar thing for the {{JdbcMetaTablesRequest#readBinary}}: 
in case old client + new server we just change behaviour - we start returning 
extra "tables" meta for type "VIEW". Users are unable to filter out these 
tables. So here we should do the decision, for ald clients what we do 1. Always 
return "TABLE"s + "VIEW"s 2. Return only "TABLES" and never "VIEW"s.
3.2) Suggestion: in {{JdbcThinDatabaseMetadata#getTables}} should we throw an 
sql exception in case of unsupported type is specified?
 
4)Minor: {{ColumnInformation}} - would you please add info about special values 
for the {{precision}} and {{scale}} (in case column is not a decimal type)?
5)Minor: You've modified return type of the 
{{org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler#dispatchBatchOrdered}}
 which always returns {{null}}, is it better to move this type to {{void}} 
(with {{executeBatchOrdered}})?

6)Question:
{code:java}
CacheGroupDescriptor cacheGrpDesc = 
ctx.cache().cacheGroupDescriptors().get(cacheGrpId);

// We should skip table in case in case regarding cache group has been 
if (cacheGrpDesc == null)
    return null;
{code}

I really didn't know about this, would you please share knowledge, in what 
cases we could get this cache group descriptor == {{null}}? Would you point me 
to the test case?

> Views don't show in Dbeaver
> ---------------------------
>
>                 Key: IGNITE-11470
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11470
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Yury Gerzhedovich
>            Assignee: Yury Gerzhedovich
>            Priority: Major
>              Labels: iep-29
>             Fix For: 2.8
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> At Database navigator tab we can see no a views. As of now we should see at 
> least SQL system views.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to