[
https://issues.apache.org/jira/browse/IGNITE-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858662#comment-16858662
]
Maxim Muzafarov commented on IGNITE-11899:
------------------------------------------
[~agura]
Thank a lot for your interest!
Agree here with all your points.
I propose the following steps:
# Proceed to merge the current PR `as is`. We need to be sure that no other
already configured rules will be violated while we are fixing all code style
issues which are not covered by checkstyle plugin yet. Can you help?
# I've created a set of issues to fix all your comments once and for all
simultaneously with protecting changes by automatic checks.
https://issues.apache.org/jira/browse/IGNITE-11902 – MagicNumbers
https://issues.apache.org/jira/browse/IGNITE-11903 – JavadocStyle
https://issues.apache.org/jira/browse/IGNITE-11904 – JavadocVariable
Currently, all these issues are unassigned, but I'll do them with your support.
Will you help me here in future?
> Fix code style violation
> ------------------------
>
> Key: IGNITE-11899
> URL: https://issues.apache.org/jira/browse/IGNITE-11899
> Project: Ignite
> Issue Type: Bug
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> All the code style issues must be fixed, see the sample below.
> {code}
> [09:38:03] [Step 2/2] [ERROR]
> /opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:50:
> 'VARIABLE_DEF' should be separated from previous statement.
> [EmptyLineSeparator]
> [09:38:03] [Step 2/2] [ERROR]
> /opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:183:
> 'VARIABLE_DEF' should be separated from previous statement.
> [EmptyLineSeparator]
> [09:38:03] [Step 2/2] [ERROR]
> /opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:187:
> 'VARIABLE_DEF' should be separated from previous statement.
> [EmptyLineSeparator]
> [09:38:03] [Step 2/2] [ERROR]
> /opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:191:
> 'VARIABLE_DEF' should be separated from previous statement.
> [EmptyLineSeparator]
> {code}
> TC log:
> https://ci.ignite.apache.org/viewLog.html?buildId=4062737&buildTypeId=IgniteTests24Java8_CheckCodeStyle&tab=buildLog&branch_IgniteTests24Java8=%3Cdefault%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
