[ https://issues.apache.org/jira/browse/IGNITE-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884683#comment-16884683 ]
Andrey Gura edited comment on IGNITE-11927 at 7/14/19 1:53 PM: --------------------------------------------------------------- Anyway, I've took a look and have some comments: 1. There is no need to be disabled or enabled for particular metric value. So {{disabled}} flag in {{AbstractMetric}} is redundant. 2. We enable or disable metrics for one source of metrics. So we can just remove {{MetricRegistry}} from {{GridMetricManager}} when metrics disabled. 3. There is no need for {{disabled}} flag in {{MetricRegistry}}. As we discused early, when metric disabled they don't consume any memory. MetricsRegistry should be collected by GC. After enabling it can be created and registered into {{GridMetricManager}} again. 4. Please, separate buckets configuration and metrics enabling/disabling into two different tickets. 5. Please, create review in Upsource. 6. Please, run TC and take a look to results before code review. Could you please fix this issues? Thanks. was (Author: agura): Anyway, I've took a look and have some comments: 1. There is no need to be disabled or enabled for particular metric value. So {{disabled}} flag in {{AbstractMetric}} is redundant. 2. We enable or disable metrics for one source of metrics. So we can just remove {{MetricRegistry}} from {{GridMetricManager}} when metrics disabled. 3. There is no need for {{disabled}} flag in {{MetricRegistry}}. As we discused early, when metric disabled they don't consume any memory. MetricsRegistry should be collected by GC. After enabling it can be created and registered into {{GridMetricManager}} again. 4. Please, separate buckets configuration and metrics enabling/disabling into two different tickets. 5. Please, create review in Upsource. 6. Please, run TC and take a look to results before code review. > [IEP-35] Add ability to configure subset of metrics > --------------------------------------------------- > > Key: IGNITE-11927 > URL: https://issues.apache.org/jira/browse/IGNITE-11927 > Project: Ignite > Issue Type: Improvement > Reporter: Nikolay Izhikov > Assignee: Nikolay Izhikov > Priority: Major > Labels: IEP-35 > Time Spent: 10m > Remaining Estimate: 0h > > Ignite should be able to: > * Enable or disable an arbitrary subset of the metrics. User should be able > to do it in runtime. > * Configure Histogram metrics > * Configure HitRate metrics. > We should provide 2 ways to configure metric: > 1. -Configuration file.- Discussed on dev-list. Agreed to go with the > simplest solution - JMX method. > 2. JMX method. -- This message was sent by Atlassian JIRA (v7.6.14#76016)