[ 
https://issues.apache.org/jira/browse/IGNITE-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887827#comment-16887827
 ] 

Maxim Muzafarov commented on IGNITE-11799:
------------------------------------------

[~ascherbakov]

Hello, can you please clarify? The issue is closed as `won't fix`, but the 
comment is still persist. Should we remove it?
org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java:799

{code}
// It's important to clear non empty moving partitions before full rebalancing.
// Consider the scenario:
// Node1 has keys k1 and k2 in the same partition.
// Node2 started rebalancing from Node1.
// Node2 received k1, k2 and failed before moving partition to OWNING state.
// Node1 removes k2 but update has not been delivered to Node1 because of 
failure.
// After new full rebalance Node1 will only send k1 to Node2 causing lost 
removal.
// NOTE: avoid calling clearAsync for partition twice per topology version.
// TODO FIXME clearing is not always needed see IGNITE-11799
{code}

> Do not always clear partition in MOVING state before exchange
> -------------------------------------------------------------
>
>                 Key: IGNITE-11799
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11799
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexei Scherbakov
>            Assignee: Alexei Scherbakov
>            Priority: Major
>
> After IGNITE-10078 if partition was in moving state before exchange and 
> choosed for full rebalance (for example, this will happen if any minor PME 
> cancels previous rebalance) we always will clear it to avoid desync issues if 
> some removals were not delivered to demander.
> This is not necessary to do if previous rebalance was full.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to