[
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888630#comment-16888630
]
Anton Vinogradov commented on IGNITE-11921:
-------------------------------------------
[~NIzhikov],
Checked the code.
A don't like
- explicit type usage at fields and method params. Interface should be used.
- implementation hiding methods like {noformat}mreg.longMetric(...){noformat}
(it's not cleat it based on {{AtomicLong}}).
Also, I'm not sure its a good case to use {{AtomicLong}} based counter since
they may slowdown the system, seems every counter should be replaced with
{{LongAdder}}.
Do we really need {{AtomicLong}} implementation?
So, my ALGTM for now :)
Please check the TC before the merge.
> [IEP-35] Migrate CacheGroupMetrics
> ----------------------------------
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
> Issue Type: Improvement
> Reporter: Nikolay Izhikov
> Assignee: Nikolay Izhikov
> Priority: Major
> Labels: IEP-35
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to
> the new metric framework.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
